Code

Update Clippy#84001

Code

Merged

bors merged 144 commits intorust-lang:masterrust-lang/rust:masterfrom

flip1995:clippyupflip1995/rust:clippyupCopy head branch name to clipboard

Apr 8, 2021

Commits

Commits on Mar 25, 2021

• Merge commit '0e87918536b9833bbc6c683d1f9d51ee2bf03ef1' into clippyup

  flip1995

  committed
  9f6b5de

  Copy full SHA for 9f6b5de

• Updated changelog for 1.52

  Show description for 3a4c0a7
  

  2 peopleauthored and

  flip1995

  committed
  3a4c0a7

  Copy full SHA for 3a4c0a7

• Auto merge of #6961 - xFrednet:changelog-1-52, r=flip1995

  Show description for f41d68f
  bors

  committed
  f41d68f

  Copy full SHA for f41d68f

Commits on Mar 26, 2021

• Improve `redundant_slicing`

  Show description for 0ff68bb
  Jarcho

  committed
  0ff68bb

  Copy full SHA for 0ff68bb

• Auto merge of #6975 - Jarcho:redundant_slicing_fp, r=llogiq

  Show description for 63aca96
  bors

  committed
  63aca96

  Copy full SHA for 63aca96

• Move absurd_extreme_comparisons to its own module

  Y-Nak

  committed
  caa49c8

  Copy full SHA for caa49c8

• Move invalid_upcast_comparisons to its own module

  Y-Nak

  committed
  f231b59

  Copy full SHA for f231b59

• Move implicit_hasher to its own module

  Y-Nak

  committed
  dad39b6

  Copy full SHA for dad39b6

• Fix FN that types lints don't work with const or static

  Y-Nak

  committed
  494bc8a

  Copy full SHA for 494bc8a

• Fix inconsistent test names

  Y-Nak

  committed
  bd1201a

  Copy full SHA for bd1201a

• Merge type_complexity pass into types pass

  Y-Nak

  committed
  818f832

  Copy full SHA for 818f832

• Add MSRV option to unnested_or_patterns lint

  flip1995

  committed
  1a1adad

  Copy full SHA for 1a1adad

• Improve doc on how to add MSRV to a lint

  flip1995

  committed
  9ce9989

  Copy full SHA for 9ce9989

• Fix trailing whitespaces in doc/adding_lints.md

  flip1995

  committed
  5279b59

  Copy full SHA for 5279b59

• Auto merge of #6977 - flip1995:or_patterns_msrv, r=llogiq

  Show description for 6f2a6fe
  bors

  committed
  6f2a6fe

  Copy full SHA for 6f2a6fe

• Add missing lints to MSRV config doc

  flip1995

  committed
  5351bbf

  Copy full SHA for 5351bbf

• Use iter::zip in src/tools/clippy/

  cuviper

  committed
  0dddfbf

  Copy full SHA for 0dddfbf

• upper_case_acronyms: only lint enum variants if the enum is not public

  matthiaskrgr

  committed
  4e19d40

  Copy full SHA for 4e19d40

Commits on Mar 27, 2021

• upper_case_acronyms: add ui and ui-toml tests for private/public enums

  matthiaskrgr

  committed
  ca7e955

  Copy full SHA for ca7e955

• format macro argument parsing fix

  Show description for ce4e668
  osa1

  committed
  ce4e668

  Copy full SHA for ce4e668

• `len_without_is_empty` improvements

  Show description for 12985af
  Jarcho

  committed
  12985af

  Copy full SHA for 12985af

• Auto merge of #6980 - Jarcho:len_without_is_empty_sig, r=llogiq

  Show description for dcee00d
  bors

  committed
  dcee00d

  Copy full SHA for dcee00d

• Auto merge of #6979 - flip1995:msrv_doc_fix, r=giraffate

  Show description for 8e56a2b
  bors

  committed
  8e56a2b

  Copy full SHA for 8e56a2b

• Move too_many_arguments to its own module

  Y-Nak

  committed
  febf34e

  Copy full SHA for febf34e

• Move too_many_lines to its own module

  Y-Nak

  committed
  7c028de

  Copy full SHA for 7c028de

• move not_unsafe_ptr_arg_deref to its own module

  Y-Nak

  committed
  9782fc4

  Copy full SHA for 9782fc4

• Move lints related to must_use to their own module

  Y-Nak

  committed
  c379165

  Copy full SHA for c379165

• Move result_unit_err to its own module

  Y-Nak

  committed
  add3e50

  Copy full SHA for add3e50

• Rollup merge of #82917 - cuviper:iter-zip, r=m-ou-se

  Show description for b094bb1
  Dylan-DPC

  authored
  b094bb1

  Copy full SHA for b094bb1

• redundant_pattern_matching: look inside Refs

  Show description for e006c77
  matthiaskrgr

  committed
  e006c77

  Copy full SHA for e006c77

Commits on Mar 28, 2021

• Remove (lots of) dead code

  Show description for a57a8c3
  jyn514

  committed
  a57a8c3

  Copy full SHA for a57a8c3

• Improve `expl_impl_clone_on_copy`

  Show description for 879fa5c
  Jarcho

  committed
  879fa5c

  Copy full SHA for 879fa5c

• Auto merge of #6991 - matthiaskrgr:5396, r=giraffate

  Show description for 4bcc552
  bors

  committed
  4bcc552

  Copy full SHA for 4bcc552

• Auto merge of #6993 - Jarcho:expl_impl_clone, r=llogiq

  Show description for c07103b
  bors

  committed
  c07103b

  Copy full SHA for c07103b

Commits on Mar 29, 2021

• Fix inconsistent test name

  Y-Nak

  committed
  1f95940

  Copy full SHA for 1f95940

• missing_panics_doc: Ignore usage of debug_assert family

  Y-Nak

  committed
  31afdfc

  Copy full SHA for 31afdfc

• Auto merge of #6996 - Y-Nak:missing_panics_doc, r=Manishearth

  Show description for 0e06b3c
  bors

  committed
  0e06b3c

  Copy full SHA for 0e06b3c

• Improve `clone_on_copy`

  Show description for d265776
  Jarcho

  committed
  d265776

  Copy full SHA for d265776

• Use uppercase for MSRV

  giraffate

  committed
  23508a1

  Copy full SHA for 23508a1

Commits on Mar 30, 2021

• Auto merge of #7003 - giraffate:use_uppercase_for_msrv, r=camsteffen

  Show description for a521445
  bors

  committed
  a521445

  Copy full SHA for a521445

• Improve documents in functions group

  Y-Nak

  committed
  541c8b8

  Copy full SHA for 541c8b8

• Auto merge of #6990 - Y-Nak:refactor-functions, r=giraffate

  Show description for 1ddeaa6
  bors

  committed
  1ddeaa6

  Copy full SHA for 1ddeaa6

• Auto merge of #7000 - Jarcho:clone_on_copy_fp, r=llogiq

  Show description for 0552852
  bors

  committed
  0552852

  Copy full SHA for 0552852

• wrong_self_convention: fix FP inside trait impl for `to_*` method

  Show description for 6966c78
  mgacek8

  committed
  6966c78

  Copy full SHA for 6966c78

• Fix `manual_map` at the end of an if chain

  Jarcho

  committed
  fa689f8

  Copy full SHA for fa689f8

• Auto merge of #7004 - Jarcho:manual_map_if_then_else, r=camsteffen

  Show description for 44bf60f
  bors

  committed
  44bf60f

  Copy full SHA for 44bf60f

• Don't lint `manual_map` in const functions

  Jarcho

  committed
  cc7f1da

  Copy full SHA for cc7f1da

• Remove hir::CrateItem.

  cjgillot

  committed
  d121b34

  Copy full SHA for d121b34

• Add non_octal_unix_permissions lint

  ebobrow

  committed
  7fcd155

  Copy full SHA for 7fcd155

• Auto merge of #7001 - ebobrow:non-octal-file-permissions, r=Manishearth

  Show description for 4be72b0
  bors

  committed
  4be72b0

  Copy full SHA for 4be72b0

Commits on Mar 31, 2021

• result_unit_err: Fix typo

  Y-Nak

  committed
  45164de

  Copy full SHA for 45164de

• Auto merge of #7007 - Y-Nak:result_unit_err, r=giraffate

  Show description for 0b76719
  bors

  committed
  0b76719

  Copy full SHA for 0b76719

• Fix hidden variant suggestion on single variant

  Show description for 8abab55
  

  Michael Wright

  committed
  8abab55

  Copy full SHA for 8abab55

• update lintcheck logs

  matthiaskrgr

  committed
  6ee1469

  Copy full SHA for 6ee1469

• lintcheck: warn if checking a program results in bad exit status

  matthiaskrgr

  committed
  225f7e0

  Copy full SHA for 225f7e0

• Track bound vars

  jackh726

  committed
  b438e30

  Copy full SHA for b438e30

• Auto merge of #6938 - Y-Nak:refactor-types, r=flip1995

  Show description for 2e33bf6
  bors

  committed
  2e33bf6

  Copy full SHA for 2e33bf6

• Auto merge of #6981 - matthiaskrgr:6803_take_2, r=flip1995

  Show description for 3e42c35
  bors

  committed
  3e42c35

  Copy full SHA for 3e42c35

• New Lint: excessive_for_each

  Y-Nak

  committed
  5029dc8

  Copy full SHA for 5029dc8

• Fix codes that fails dogfood

  Y-Nak

  committed
  3095253

  Copy full SHA for 3095253

• Change a category of excessive_for_each: Style -> Restriction

  Y-Nak

  committed
  54a0471

  Copy full SHA for 54a0471

• Trigger the lint iff exposure's body is ExprKind::Block.

  Y-Nak

  committed
  5bb0f16

  Copy full SHA for 5bb0f16

• Avoid to suggest using label

  Y-Nak

  committed
  90cbbb2

  Copy full SHA for 90cbbb2

• Refactor: Remove duplicated codes from excessive_for_each

  Y-Nak

  committed
  ccd7a60

  Copy full SHA for ccd7a60

• Add comments to clarify why RetCollector is needed

  Y-Nak

  committed
  25d8b94

  Copy full SHA for 25d8b94

• Improve the document of excessive_for_each

  Y-Nak

  committed
  3843171

  Copy full SHA for 3843171

• Use ".." as default value of snippet in excessive_for_each

  Y-Nak

  committed
  5543c34

  Copy full SHA for 5543c34

• Refactor excessive_for_each

  Y-Nak

  committed
  527fbbe

  Copy full SHA for 527fbbe

• Remove method_calls

  Y-Nak

  committed
  f2cc995

  Copy full SHA for f2cc995

• Fix codes that make dogfood fail

  Y-Nak

  committed
  1109dc8

  Copy full SHA for 1109dc8

• Skip needless_for_each if an input stmt is local

  Y-Nak

  committed
  bf1e3f7

  Copy full SHA for bf1e3f7

• Tweak a suggestion message of needless_for_each

  Y-Nak

  committed
  e61f978

  Copy full SHA for e61f978

• Suggest `flatten` instead of `is_some` -> `unwrap`

  

  Eric Loren

  committed
  56fbbf7

  Copy full SHA for 56fbbf7

• Auto merge of #6706 - Y-Nak:excessive-for-each, r=camsteffen

  Show description for c1021b8
  bors

  committed
  c1021b8

  Copy full SHA for c1021b8

• Auto merge of #6342 - bbqbaron:issue-6061, r=flip1995

  Show description for 775ef47
  bors

  committed
  775ef47

  Copy full SHA for 775ef47

• Destructure args in methods module

  camsteffen

  committed
  2108387

  Copy full SHA for 2108387

• Auto merge of #6913 - camsteffen:method-chain, r=flip1995

  Show description for 487c2e8
  bors

  committed
  487c2e8

  Copy full SHA for 487c2e8

• Auto merge of #7008 - matthiaskrgr:ltchk, r=camsteffen

  Show description for 459bca8
  bors

  committed
  459bca8

  Copy full SHA for 459bca8

• Add if_chain lints

  camsteffen

  committed
  5f887d0

  Copy full SHA for 5f887d0

• Eat dogfood

  camsteffen

  committed
  827d6aa

  Copy full SHA for 827d6aa

• Fix `redundant_clone` fp where the cloned value is modified while the clone is in use.

  Jarcho

  committed
  aaba9b7

  Copy full SHA for aaba9b7

• Auto merge of #7010 - camsteffen:if-chain-lint, r=llogiq

  Show description for 8cf7d9b
  bors

  committed
  8cf7d9b

  Copy full SHA for 8cf7d9b

Commits on Apr 1, 2021

• clippy_utils: fix needless parenthesis output from sugg::Sugg::maybe_par

  Y-Nak

  committed
  6325fe1

  Copy full SHA for 6325fe1

• Auto merge of #6976 - Jarcho:manual_map_const, r=phansch

  Show description for 75d73e9
  bors

  committed
  75d73e9

  Copy full SHA for 75d73e9

• Auto merge of #7002 - mgacek8:issue6983_wrong_self_convention_inside_trait_impls, r=phansch

  Show description for 38b1fd0
  bors

  committed
  38b1fd0

  Copy full SHA for 38b1fd0

• Auto merge of #7011 - Jarcho:redundant_clone_fp, r=flip1995

  Show description for 92c4fc3
  bors

  committed
  92c4fc3

  Copy full SHA for 92c4fc3

• Auto merge of #7013 - Y-Nak:fix-needless-paren, r=flip1995

  Show description for 72eb60a
  bors

  committed
  72eb60a

  Copy full SHA for 72eb60a

• Remove paths from bind_instead_of_map

  camsteffen

  committed
  08a8ad3

  Copy full SHA for 08a8ad3

Commits on Apr 2, 2021

• same_item_push: Don't trigger same_item_push if the vec is used in the loop body

  Y-Nak

  committed
  9f6f001

  Copy full SHA for 9f6f001

• Auto merge of #6988 - mikerite:fix-6984, r=camsteffen

  Show description for 1931db2
  bors

  committed
  1931db2

  Copy full SHA for 1931db2

• Refactor needless_collect

  camsteffen

  committed
  a064534

  Copy full SHA for a064534

• Remove redundant emit()

  camsteffen

  committed
  4356a8f

  Copy full SHA for 4356a8f

• Auto merge of #7016 - camsteffen:bind-map-paths, r=Manishearth

  Show description for 9ce2373
  bors

  committed
  9ce2373

  Copy full SHA for 9ce2373

• Improve needless_collect output

  camsteffen

  committed
  33798bb

  Copy full SHA for 33798bb

• Auto merge of #7020 - camsteffen:needless-collect, r=Manishearth

  Show description for 86fb0e8
  bors

  committed
  86fb0e8

  Copy full SHA for 86fb0e8

• fix clippy error

  roxelo

  committed
  2ca5368

  Copy full SHA for 2ca5368

Commits on Apr 3, 2021

• Remove attribute `#[link_args]`

  petrochenkov

  committed
  c726448

  Copy full SHA for c726448

• Fix ICE

  camsteffen

  committed
  7014340

  Copy full SHA for 7014340

• Remove author requirement for `cargo_common_metadata`

  daxpedda

  committed
  5102c9c

  Copy full SHA for 5102c9c

• Use DefIdMap and similar aliases

  camsteffen

  committed
  6f31ed6

  Copy full SHA for 6f31ed6

Commits on Apr 4, 2021

• added core::panicking::assert_failed_inner as panicking

  ABouttefeux

  committed
  984ab98

  Copy full SHA for 984ab98

• modification not working: fixing

  ABouttefeux

  committed
  2f81e4e

  Copy full SHA for 2f81e4e

• Adding a dark theme to the clippy lint list

  xFrednet

  committed
  e25b106

  Copy full SHA for e25b106

• Auto merge of #7030 - xFrednet:6877-clippy-going-dark, r=llogiq

  Show description for 6bb608c
  bors

  committed
  6bb608c

  Copy full SHA for 6bb608c

• Quick fix to access the correct css files

  xFrednet

  committed
  da04e87

  Copy full SHA for da04e87

• Rollup merge of #83820 - petrochenkov:nolinkargs, r=nagisa

  Show description for 44e3ccb
  Dylan-DPC

  authored
  44e3ccb

  Copy full SHA for 44e3ccb

• Auto merge of #7021 - camsteffen:7012, r=giraffate

  Show description for a15d987
  bors

  committed
  a15d987

  Copy full SHA for a15d987

Commits on Apr 5, 2021

• Fix ICE in `missing_panics_doc`

  Jarcho

  committed
  a00de90

  Copy full SHA for a00de90

• add test for missing_panic_doc on assert_eq/assert_ne

  ABouttefeux

  committed
  8e5dd4b

  Copy full SHA for 8e5dd4b

• Auto merge of #7031 - xFrednet:5234-quick-fix-dark-mode-themes, r=llogiq

  Show description for e315437
  bors

  committed
  e315437

  Copy full SHA for e315437

• Auto merge of #7027 - camsteffen:defidmap, r=phansch

  Show description for 8d221c5
  bors

  committed
  8d221c5

  Copy full SHA for 8d221c5

• Auto merge of #7034 - Jarcho:missing_doc_ice, r=phansch

  Show description for 81f9946
  bors

  committed
  81f9946

  Copy full SHA for 81f9946

• Added documentation to the multispan_sugg method

  xFrednet

  committed
  232e2b7

  Copy full SHA for 232e2b7

• A new lint for shared code in if blocks

  Show description for d1df732
  xFrednet

  committed
  d1df732

  Copy full SHA for d1df732

• The shared_code_in_if_blocks lint only operats on entire if expr not else ifs

  xFrednet

  committed
  469ff96

  Copy full SHA for 469ff96

• Improved shared_code_in_if_blocks output readability and added tests

  xFrednet

  committed
  8efc6ac

  Copy full SHA for 8efc6ac

• Improved shared_code_in_if_blocks message and added test stderrs

  xFrednet

  committed
  b1d26e5

  Copy full SHA for b1d26e5

• Updated code for dogfood

  xFrednet

  committed
  65ed5a6

  Copy full SHA for 65ed5a6

• Adapted the lint to use the new SpanlessEq

  xFrednet

  committed
  c74e49e

  Copy full SHA for c74e49e

• Moving shared_code_in_if_blocks to clippy::complexity and running lintcheck

  xFrednet

  committed
  617c65b

  Copy full SHA for 617c65b

• Only running shared_code_in_if_blocks only for if statements

  xFrednet

  committed
  8c0b4d7

  Copy full SHA for 8c0b4d7

• Test for empty blocks and update from master

  xFrednet

  committed
  7c9e192

  Copy full SHA for 7c9e192

• Renaming the lint to branches_sharing_code and fixing typos

  xFrednet

  committed
  a6f54f5

  Copy full SHA for a6f54f5

• Auto merge of #7026 - daxpedda:cargo-author, r=camsteffen

  Show description for 1a45e43
  bors

  committed
  1a45e43

  Copy full SHA for 1a45e43

• Auto merge of #6463 - xFrednet:5234-shared-code-in-if-blocks, r=phansch

  Show description for d91da40
  bors

  committed
  d91da40

  Copy full SHA for d91da40

• Auto merge of #7029 - ABouttefeux:master, r=Manishearth

  Show description for 25c1ed3
  bors

  committed
  25c1ed3

  Copy full SHA for 25c1ed3

• Auto merge of #7018 - Y-Nak:same_item_push, r=Manishearth

  Show description for 57406c9
  bors

  committed
  57406c9

  Copy full SHA for 57406c9

Commits on Apr 6, 2021

• consider mutability on useless_vec suggestions

  Show description for 8a50923
  hmacias-avaya

  committed
  8a50923

  Copy full SHA for 8a50923

• Use AnonConst for asm! constants

  Amanieu

  committed
  879bfec

  Copy full SHA for 879bfec

• Auto merge of #7036 - horacimacias:master, r=giraffate

  Show description for d2ba777
  bors

  committed
  d2ba777

  Copy full SHA for d2ba777

• Fix all occurences of `needless_borrow` internally

  Jarcho

  committed
  12fce55

  Copy full SHA for 12fce55

• Auto merge of #6931 - Jarcho:needless_borrow, r=phansch,flip1995

  Show description for 6ae0835
  bors

  committed
  6ae0835

  Copy full SHA for 6ae0835

• Remove get_node_span

  camsteffen

  committed
  1efb551

  Copy full SHA for 1efb551

• Remove paths::PATH_BUF

  camsteffen

  committed
  79d3082

  Copy full SHA for 79d3082

• Soft deprecate match_path and match_qpath

  camsteffen

  committed
  a342de3

  Copy full SHA for a342de3

• Auto merge of #7043 - camsteffen:dead-utils, r=flip1995

  Show description for bbe1567
  bors

  committed
  bbe1567

  Copy full SHA for bbe1567

• Auto merge of #7044 - camsteffen:match-path, r=Manishearth

  Show description for 624e8aa
  bors

  committed
  624e8aa

  Copy full SHA for 624e8aa

• Symbol optimizations

  camsteffen

  committed
  47f0c15

  Copy full SHA for 47f0c15

Commits on Apr 7, 2021

• Auto merge of #7046 - camsteffen:symbol-optimize, r=giraffate

  Show description for db6ea84
  bors

  committed
  db6ea84

  Copy full SHA for db6ea84

• Rollup merge of #83916 - Amanieu:asm_anonconst, r=petrochenkov

  Show description for cde58f7
  Dylan-DPC

  authored
  cde58f7

  Copy full SHA for cde58f7

Commits on Apr 8, 2021

• Merge remote-tracking branch 'upstream/master' into rustup

  flip1995

  committed
  ffa2b7d

  Copy full SHA for ffa2b7d

• Bump nightly version -> 2021-04-08

  flip1995

  committed
  61eafbb

  Copy full SHA for 61eafbb

• Auto merge of #7051 - flip1995:rustup, r=flip1995

  Show description for b40ea20
  bors

  committed
  b40ea20

  Copy full SHA for b40ea20

• Merge commit 'b40ea209e7f14c8193ddfc98143967b6a2f4f5c9' into clippyup

  flip1995

  committed
  6b37cd3

  Copy full SHA for 6b37cd3