Skip to content

Conversation

@syvb
Copy link
Contributor

@syvb syvb commented May 26, 2021

Iterator::{min, max} can't be used with iterators of floats due to NaN issues. This suggests a workaround in the documentation of those functions.

@rust-highfive
Copy link
Contributor

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 26, 2021
syvb and others added 2 commits May 26, 2021 20:38
@m-ou-se m-ou-se assigned m-ou-se and unassigned dtolnay May 27, 2021
@m-ou-se
Copy link
Member

m-ou-se commented May 27, 2021

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 27, 2021

📌 Commit b00f6fc has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 27, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request May 27, 2021
…laumeGomez

Rollup of 3 pull requests

Successful merges:

 - rust-lang#85722 (Fix trait methods' toggle)
 - rust-lang#85730 (Mention workaround for floats in Iterator::{min, max})
 - rust-lang#85738 (Rename opensbd to openbsd)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e30192a into rust-lang:master May 27, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants