debuginfo: Some refactoring and fix for #8670 #8684
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, I get the |
| @@ -243,7 +235,7 @@ pub fn create_argument_metadata(bcx: @mut Block, | |||
|
|
|||
| let def_map = cx.tcx.def_map; | |||
| let file_metadata = file_metadata(cx, filename); | |||
| let scope = create_function_metadata(fcx); | |||
| let scope = bcx.fcx.debug_context.get_ref().fn_metadata;//create_function_metadata(fcx); | |||
There was a problem hiding this comment.
Remove the commented out code.
bors
added a commit
that referenced
this pull request
Aug 23, 2013
… r=jdm This PR contains some code cleanup and the fix for issue #8670. ~~I am not sure about issue #8442 (could not reproduce it). @jdm, could check after this is merged and possibly close the issue then?~~ (closed now) Some interesting facts: With this commit, it should be possible to compile libstd with `-Zdebug-info` (it does not work yet with `-Zextra-debug-info` but we are getting there). Switching debug info on increases the compile time for libstd by about 2 seconds. @catamorphism I get one failing test in rustpkg: `package_script_with_default_build` says: `task <unnamed> failed at 'Couldn't copy file', /home/mw/rust/src/librustpkg/tests.rs:689` Would you have any idea what that is about? Seems be something wrong on my machine... Cheers, Michael Fixes #8670
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some code cleanup and the fix for issue #8670.
I am not sure about issue #8442 (could not reproduce it). @jdm, could check after this is merged and possibly close the issue then?(closed now)Some interesting facts: With this commit, it should be possible to compile libstd with
-Zdebug-info(it does not work yet with-Zextra-debug-infobut we are getting there). Switching debug info on increases the compile time for libstd by about 2 seconds.@catamorphism I get one failing test in rustpkg:
package_script_with_default_buildsays:task <unnamed> failed at 'Couldn't copy file', /home/mw/rust/src/librustpkg/tests.rs:689Would you have any idea what that is about? Seems be something wrong on my machine...
Cheers,
Michael
Fixes #8670