Skip to content

Suggest br if the unknown string prefix rb is found #87662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2021

Conversation

FabianWolff
Copy link
Contributor

Currently, for the following code:

fn main() {
    rb"abc";
}

we issue the following suggestion:

help: consider inserting whitespace here
  |
2 |     rb "abc";
  |       --

With my changes (only in edition 2021, where unknown prefixes became an error), I get:

help: use `br` for a raw byte string
  |
2 |     br"abc";
  |     ^^

@rust-highfive
Copy link
Contributor

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 31, 2021
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 31, 2021

📌 Commit f2c9654 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2021
@bors
Copy link
Collaborator

bors commented Jul 31, 2021

⌛ Testing commit f2c9654 with merge 4e28279...

@bors
Copy link
Collaborator

bors commented Jul 31, 2021

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 4e28279 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 31, 2021
@bors bors merged commit 4e28279 into rust-lang:master Jul 31, 2021
@rustbot rustbot added this to the 1.56.0 milestone Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants