Skip to content

Avoid adjusting TLS data twice for queries #90139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Oct 21, 2021

Based on #86038

Each query adjusts TLS information twice: once to adjust job id and record diagnostics, and once to record dependencies. This PR attempts to do it only once using dedicated functions for queries.

r? @Mark-Simulacrum
Blocked on #86038

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 21, 2021
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 21, 2021
@bors
Copy link
Collaborator

bors commented Oct 21, 2021

⌛ Trying commit 30b9d2b2726897caf735d37a6513a827c28d2744 with merge 019045026f3de24da13181f3957033803b0451a2...

@bors
Copy link
Collaborator

bors commented Oct 21, 2021

☀️ Try build successful - checks-actions
Build commit: 019045026f3de24da13181f3957033803b0451a2 (019045026f3de24da13181f3957033803b0451a2)

@rust-timer
Copy link
Collaborator

Queued 019045026f3de24da13181f3957033803b0451a2 with parent e015ef5, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (019045026f3de24da13181f3957033803b0451a2): comparison url.

Summary: This change led to large relevant mixed results 🤷 in compiler performance.

  • Large improvement in instruction counts (up to -1.4% on incr-full builds of unused-warnings)
  • Moderate regression in instruction counts (up to 0.6% on full builds of inflate)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 22, 2021
@Mark-Simulacrum
Copy link
Member

r=me, but let's confirm perf after #86038 merges

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2021
@bors
Copy link
Collaborator

bors commented Oct 25, 2021

☔ The latest upstream changes (presumably #90210) made this pull request unmergeable. Please resolve the merge conflicts.

@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 28, 2021
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 14, 2021
@cjgillot cjgillot marked this pull request as draft December 10, 2021 11:38
@Dylan-DPC Dylan-DPC added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 22, 2022
@cjgillot cjgillot closed this Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants