Skip to content

[EXPERIMENT] rustdoc: Mark Context::tcx() as #[inline(always)] #90411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

camelid
Copy link
Member

@camelid camelid commented Oct 29, 2021

I'm wondering if tcx() not being inlined could be affecting the perf in #90391.

r? @ghost

@camelid camelid added I-compiletime Issue: Problems and improvements with respect to compile times. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 29, 2021
@camelid
Copy link
Member Author

camelid commented Oct 29, 2021

It could also make sense to move tcx out of shared, since it's behind an Rc.

For now, let's see what effect this has.

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 29, 2021
@bors
Copy link
Collaborator

bors commented Oct 29, 2021

⌛ Trying commit 44b342e with merge 01cff54ade7465331b57967fce4ed7060b1a1971...

@bors
Copy link
Collaborator

bors commented Oct 30, 2021

☀️ Try build successful - checks-actions
Build commit: 01cff54ade7465331b57967fce4ed7060b1a1971 (01cff54ade7465331b57967fce4ed7060b1a1971)

@rust-timer
Copy link
Collaborator

Queued 01cff54ade7465331b57967fce4ed7060b1a1971 with parent e99963c, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (01cff54ade7465331b57967fce4ed7060b1a1971): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 30, 2021
@camelid
Copy link
Member Author

camelid commented Oct 30, 2021

Hmm, mixed or slightly negative results.

@camelid camelid closed this Oct 30, 2021
@camelid camelid deleted the inline-always branch October 30, 2021 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-compiletime Issue: Problems and improvements with respect to compile times. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants