-
Notifications
You must be signed in to change notification settings - Fork 13.3k
rustbot: Add autolabeling for T-rustdoc
#91817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit adds autolabeling for the `T-rustdoc` label, for PRs that modify rustdoc's source code, tests, or internal tooling. This is possible now that rust-lang/triagebot#1321 has landed.
(rust-highfive has picked a reviewer for you, use r? to override) |
"src/test/rustdoc-gui", | ||
"src/test/rustdoc-js", | ||
"src/test/rustdoc-js-std", | ||
"src/test/rustdoc-json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In practice we're currently using a str::starts_with, so just src/test/rustdoc is technically enough, but this seems harmless so likely OK (and we may want to alter that to a Path prefix).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I didn't realize that! It's probably good to have the paths here not rely on that behavior though :)
@bors r+ rollup |
📌 Commit dce45a9 has been approved by |
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#91746 (Btree: assert more API compatibility) - rust-lang#91748 (rustdoc: Add regression test for Iterator as notable trait on &mut T) - rust-lang#91811 (bootstrap: Change unwrap() to expect() for WIX path) - rust-lang#91814 (doc: fix typo in comments) - rust-lang#91815 (better span for unexpected normalization failure in CTFE engine) - rust-lang#91817 (rustbot: Add autolabeling for `T-rustdoc`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This commit adds autolabeling for the
T-rustdoc
label, for PRs thatmodify rustdoc's source code, tests, or internal tooling.
This is possible now that rust-lang/triagebot#1321 has landed.