Skip to content

Fix Union field suggestions #93320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix Union field suggestions #93320

wants to merge 1 commit into from

Conversation

terrarier2111
Copy link
Contributor

Fixes: #93122

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 26, 2022
@rust-highfive
Copy link
Contributor

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 26, 2022
@jackh726
Copy link
Member

I dont think this is the right solution. FWICT, this would mean we no longer get any suggestions to access fields of type (). (Its arguably not super useful, but we should still try). I'm surprised we don't test coverage for that.

@terrarier2111
Copy link
Contributor Author

terrarier2111 commented Feb 9, 2022 •
edited
Loading

I dont think this is the right solution. FWICT, this would mean we no longer get any suggestions to access fields of type (). (Its arguably not super useful, but we should still try). I'm surprised we don't test coverage for that.

Okay, so how should we proceed? Should i close this pr or should I add a FIXME to address the missing suggestions for union types?

@jackh726
Copy link
Member

Can you try to make a test where we currently suggesting accessing a unit field?

@jackh726 jackh726 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2022
@terrarier2111
Copy link
Contributor Author

Can you try to make a test where we currently suggesting accessing a unit field?

Sorry for the late response, after some testing i wasn't able to get a suggestion for an unit field at all.

@JohnCSimon
Copy link
Member

@terrarier2111
Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.
Thanks for your contribution.

@rustbot label: +S-inactive

@JohnCSimon JohnCSimon closed this Apr 11, 2022
@rustbot rustbot added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jackh726 jackh726

Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error message for trying to bind range of units to unit suggests invalid code
5 participants
@terrarier2111 @rust-highfive @jackh726 @JohnCSimon @rustbot