Improve unexpected_cfgs lint when their is no value expected #94561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
petrochenkov
reviewed
Mar 4, 2022
|
r=me with formatting fixed #94561 (review) |
petrochenkov
added
S-waiting-on-author
Urgau
force-pushed
the
check-cfg-lint-help-remove
branch
from
456496c to
3be6ccd
Compare
|
CI pass but blocked on #94362 being merged first as some output files will change. |
|
#94362 has been merged. |
Urgau
force-pushed
the
check-cfg-lint-help-remove
branch
from
3be6ccd to
92544f4
Compare
|
@bors r+ |
|
📌 Commit 92544f4 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (c8a49fc): comparison url. Summary: This benchmark run did not return any relevant results. 1 results were found to be statistically significant but too small to be relevant. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request improve the
unexpected_cfgswhen their is no value expected by suggesting to remove the value.I also took the liberty to special case it for
featureas it seems wrong to suggest to remove the value when the problem is most probably the absence of value(s) and also the fact that it doesn't make sense to only havefeaturewithout a value.r? @petrochenkov