Rollup of 6 pull requests #96426
Closed
Rollup of 6 pull requests #96426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trait impls are still insta-stable yeah...?
Not fired yet.
…an-DPC Clarify that `Cow::into_owned` returns owned data Two sections of the `Cow::into_owned` docs imply that `into_owned` returns a `Cow`. Clarify that it returns the underlying owned object, either cloned or extracted from the `Cow`.
Implement Default for AssertUnwindSafe Trait impls are still insta-stable yeah...?
Implement a lint to warn about unused macro rules This implements a new lint to warn about unused macro rules (arms/matchers), similar to the `unused_macros` lint added by rust-lang#41907 that warns about entire macros. ```rust macro_rules! unused_empty { (hello) => { println!("Hello, world!") }; () => { println!("empty") }; //~ ERROR: 1st rule of macro `unused_empty` is never used } fn main() { unused_empty!(hello); } ``` Builds upon ~~(and currently integrates)~~ rust-lang#96149 and rust-lang#96156. Fixes rust-lang#73576
…od_error, r=estebank Cleanup `report_method_error` a bit 1. Remove an unnecessary indentation level 2. Split out a couple of large functions from this humongo function body
…bank Fix erased region escaping into wfcheck due to rust-lang#95395 We can just use `liberate_late_bound_regions` instead of `erase_late_bound_regions`... This gives us `ReEarlyBound` instead of `ReErased`, the former being something typeck actually knows how to deal with... Fixes rust-lang#96381 Side-note: We only actually get far enough in the compiler pipeline to cause this ICE when we're invoking rustdoc. We actually abort rustc right before wfcheck because of the error that we emit (having `_` in the type signature). Why does rustdoc keep going even though we raise an error?
…bound-suggestions, r=jackh726 Recover most `impl Trait` and `dyn Trait` lifetime bound suggestions under NLL This is done by replacing the duplicated (and very partial) implementation from borrowck with one inspsired from `NiceRegionError::try_report_static_impl_trait` and by re-using `suggest_new_region_bound`. Fixes rust-lang#96277 r? `@jackh726`
rustbot
added
T-compiler
|
@bors r+ rollup=never p=5 |
|
📌 Commit 7ddf9f4 has been approved by |
bors
added
the
S-waiting-on-bors
|
@bors r- @Dylan-DPC |
bors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Cow::into_ownedreturns owned data #94022 (Clarify thatCow::into_ownedreturns owned data)report_method_errora bit #96370 (Cleanupreport_method_errora bit)_in function signature inimpl Trait for Ty#95395)impl Traitanddyn Traitlifetime bound suggestions under NLL #96385 (Recover mostimpl Traitanddyn Traitlifetime bound suggestions under NLL)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup