-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Rollup of 6 pull requests #96459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Rollup of 6 pull requests #96459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Guillaume Gomez <[email protected]>
Improve Error Messaging for Unconstructed Structs and Enum Variants in Generic Contexts Improves error messaging for empty-tuple structs and enum variants in certain generic contexts. See new ui tests for examples. Closes rust-lang#87181
…od_error, r=estebank Cleanup `report_method_error` a bit 1. Remove an unnecessary indentation level 2. Split out a couple of large functions from this humongo function body
…bank Fix erased region escaping into wfcheck due to rust-lang#95395 We can just use `liberate_late_bound_regions` instead of `erase_late_bound_regions`... This gives us `ReEarlyBound` instead of `ReErased`, the former being something typeck actually knows how to deal with... Fixes rust-lang#96381 Side-note: We only actually get far enough in the compiler pipeline to cause this ICE when we're invoking rustdoc. We actually abort rustc right before wfcheck because of the error that we emit (having `_` in the type signature). Why does rustdoc keep going even though we raise an error?
…bound-suggestions, r=jackh726 Recover most `impl Trait` and `dyn Trait` lifetime bound suggestions under NLL This is done by replacing the duplicated (and very partial) implementation from borrowck with one inspsired from `NiceRegionError::try_report_static_impl_trait` and by re-using `suggest_new_region_bound`. Fixes rust-lang#96277 r? ```@jackh726```
…GuillaumeGomez rustdoc: do not write `{{root}}` in `pub use ::foo` docs Fixes rust-lang#95873
…r=notriddle Fix handling of `!` in rustdoc search Fixes rust-lang#96399. I also updated the eBNF. cc `@jsha` r? `@notriddle`
@bors r+ p=5 rollup=never |
📌 Commit c0ed53c has been approved by |
☀️ Test successful - checks-actions |
This was referenced Apr 27, 2022
Finished benchmarking commit (99b70ee): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merged-by-bors
This PR was explicitly merged by bors.
rollup
A PR which is a rollup
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
report_method_error
a bit #96370 (Cleanupreport_method_error
a bit)_
in function signature inimpl Trait for Ty
#95395)impl Trait
anddyn Trait
lifetime bound suggestions under NLL #96385 (Recover mostimpl Trait
anddyn Trait
lifetime bound suggestions under NLL){{root}}
inpub use ::foo
docs #96410 (rustdoc: do not write{{root}}
inpub use ::foo
docs)!
in rustdoc search #96430 (Fix handling of!
in rustdoc search)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup