Skip to content

Make it clear that to_ipv4 returns an IPv4 address for the IPv6 loopback #96649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2022

Conversation

tbu-
Copy link
Contributor

@tbu- tbu- commented May 2, 2022

No description provided.

@rust-highfive
Copy link
Contributor

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 2, 2022
@rust-highfive
Copy link
Contributor

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 2, 2022
@rust-log-analyzer

This comment has been minimized.

@tbu- tbu- force-pushed the pr_to_ipv4_loopback_doc branch from a65b306 to 685153d Compare May 2, 2022 21:21
@m-ou-se
Copy link
Member

m-ou-se commented May 4, 2022

Use Ipv6Addr::to_ipv4_mapped to avoid this.

to_ipv4_mapped is unstable, so we shouldn't advise users to use that method (yet).

(Perhaps it's time to stabilize that function.)

@m-ou-se m-ou-se added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2022
@tbu-
Copy link
Contributor Author

tbu- commented May 4, 2022

to_ipv4_mapped is unstable, so we shouldn't advise users to use that method (yet).

Done.

(Perhaps it's time to stabilize that function.)

Added an issue so we don't forget to recommend it after stabilization: #96718.

@m-ou-se
Copy link
Member

m-ou-se commented May 5, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented May 5, 2022

📌 Commit ed95d50 has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 5, 2022
@bors
Copy link
Collaborator

bors commented May 5, 2022

⌛ Testing commit ed95d50 with merge 322a149...

@bors
Copy link
Collaborator

bors commented May 5, 2022

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing 322a149 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 5, 2022
@bors bors merged commit 322a149 into rust-lang:master May 5, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 5, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (322a149): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants