Skip to content

rustdoc: Resolve some more doc links early 2 #96713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2022

Conversation

petrochenkov
Copy link
Contributor

The subset of #94857 that shouldn't be too expensive.

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label May 4, 2022
@rust-highfive
Copy link
Contributor

r? @jsha

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 4, 2022
@petrochenkov
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 4, 2022
@bors
Copy link
Collaborator

bors commented May 4, 2022

⌛ Trying commit 9da6155fe6c2567e87551ef74feef0497e82a6c5 with merge 26320b9f933e9393393c7362f0d75c737f4ca716...

@bors
Copy link
Collaborator

bors commented May 4, 2022

☀️ Try build successful - checks-actions
Build commit: 26320b9f933e9393393c7362f0d75c737f4ca716 (26320b9f933e9393393c7362f0d75c737f4ca716)

@rust-timer
Copy link
Collaborator

Queued 26320b9f933e9393393c7362f0d75c737f4ca716 with parent 343889b, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (26320b9f933e9393393c7362f0d75c737f4ca716): comparison url.

Summary:

  • Primary benchmarks: mixed results
  • Secondary benchmarks: no relevant changes found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count1 2 0 1 0 3
mean2 0.7% N/A -0.7% N/A 0.2%
max 0.7% N/A -0.7% N/A 0.7%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 4, 2022
@petrochenkov
Copy link
Contributor Author

r? @notriddle

@notriddle
Copy link
Contributor

This last suggestion is a pretty minor nit. If you think the iterator version is more clear, r=me

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2022
@petrochenkov
Copy link
Contributor Author

@bors r=notriddle

@bors
Copy link
Collaborator

bors commented May 16, 2022

📌 Commit 159b56f has been approved by notriddle

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 16, 2022
@bors
Copy link
Collaborator

bors commented May 16, 2022

⌛ Testing commit 159b56f with merge c1cfdd1...

@bors
Copy link
Collaborator

bors commented May 17, 2022

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing c1cfdd1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 17, 2022
@bors bors merged commit c1cfdd1 into rust-lang:master May 17, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 17, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c1cfdd1): comparison url.

Summary:

  • Primary benchmarks: mixed results
  • Secondary benchmarks: no relevant changes found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count1 1 0 1 0 2
mean2 0.6% N/A -0.9% N/A -0.2%
max 0.6% N/A -0.9% N/A -0.9%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

@rustbot rustbot removed the perf-regression Performance regression. label May 17, 2022
@petrochenkov petrochenkov deleted the doclink8 branch February 22, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants