Towards removing std::io #9749
Merged
Towards removing std::io #9749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// Reads the next line of input, interpreted as a sequence of utf-8 | ||
| /// encoded unicode codepoints. If a newline is encountered, then the | ||
| /// newline is contained in the returned string. | ||
| pub fn read_line(&mut self) -> ~str { |
There was a problem hiding this comment.
Wouldn't it make more sense to put these on ReaderUtil?
There was a problem hiding this comment.
I was actually thinking of avoiding that. The only real way to implement these with a generic read function is to read one byte at a time, and that isn't really performant at all for anything that's not a buffered reader.
|
Some comments:
I'm not sure whether it should only be defined for |
Additionally, this moves the prelude imports of print/println from std::io to std::rt::io. Closes rust-lang#6846
These two functions will be useful when replacing various other counterparts used by std::io consumers.
This changes the implementation to instead use rt::io::native::process as well as an example of using those bindings.
This was just a mistake that it was hidden.
bors
added a commit
that referenced
this pull request
Oct 10, 2013
This implements a number of the baby steps needed to start eliminating everything inside of `std::io`. It turns out that there are a *lot* of users of that module, so I'm going to try to tackle them separately instead of bringing down the whole system all at once. This pull implements a large amount of unimplemented functionality inside of `std::rt::io` including: * Native file I/O (file descriptors, *FILE) * Native stdio (through the native file descriptors) * Native processes (extracted from `std::run`) I also found that there are a number of users of `std::io` which desire to read an input line-by-line, so I added an implementation of `read_until` and `read_line` to `BufferedReader`. With all of these changes in place, I started to axe various usages of `std::io`. There's a lot of one-off uses here-and-there, but the major use-case remaining that doesn't have a fantastic solution is `extra::json`. I ran into a few compiler bugs when attempting to remove that, so I figured I'd come back to it later instead. There is one fairly major change in this pull, and it's moving from native stdio to uv stdio via `print` and `println`. Unfortunately logging still goes through native I/O (via `dumb_println`). This is going to need some thinking, because I still want the goal of logging/printing to be 0 allocations, and this is not possible if `io::stdio::stderr()` is called on each log message. Instead I think that this may need to be cached as the `logger` field inside the `Task` struct, but that will require a little more workings to get right (this is also a similar problem for print/println, do we cache `stdout()` to not have to re-create it every time?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a number of the baby steps needed to start eliminating everything inside of
std::io. It turns out that there are a lot of users of that module, so I'm going to try to tackle them separately instead of bringing down the whole system all at once.This pull implements a large amount of unimplemented functionality inside of
std::rt::ioincluding:std::run)I also found that there are a number of users of
std::iowhich desire to read an input line-by-line, so I added an implementation ofread_untilandread_linetoBufferedReader.With all of these changes in place, I started to axe various usages of
std::io. There's a lot of one-off uses here-and-there, but the major use-case remaining that doesn't have a fantastic solution isextra::json. I ran into a few compiler bugs when attempting to remove that, so I figured I'd come back to it later instead.There is one fairly major change in this pull, and it's moving from native stdio to uv stdio via
printandprintln. Unfortunately logging still goes through native I/O (viadumb_println). This is going to need some thinking, because I still want the goal of logging/printing to be 0 allocations, and this is not possible ifio::stdio::stderr()is called on each log message. Instead I think that this may need to be cached as theloggerfield inside theTaskstruct, but that will require a little more workings to get right (this is also a similar problem for print/println, do we cachestdout()to not have to re-create it every time?).