Skip to content

rm special case for ty_struct from take glue #9751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2013
Merged

rm special case for ty_struct from take glue #9751

merged 2 commits into from
Oct 8, 2013

Conversation

thestinger
Copy link
Contributor

This is incorrect, as take glue isn't used for moves.

@thestinger
rm special case for ty_struct from take glue
a9fb88d 
This is incorrect, as take glue isn't used for moves.
@thestinger
Copy link
Contributor Author

This was added for #[unsafe_no_drop_flag] but isn't necessary (as shown by the test cases existing for this already). I am pretty sure the feature is broken in edge cases because this code never did anything (it's a dead branch).

@thestinger
stop zeroing the drop flag in drop glue
f56cf16 
this is only going to cover up real bugs, as it's not part of the model
used to prevent multiple destructor calls
bors added a commit that referenced this pull request Oct 7, 2013
@bors
auto merge of #9751 : thestinger/rust/immediate, r=alexcrichton
b17dc4a 
This is incorrect, as take glue isn't used for moves.
@bors bors closed this Oct 8, 2013
@bors bors merged commit f56cf16 into rust-lang:master Oct 8, 2013
@emberian emberian mentioned this pull request Nov 30, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thestinger @bors