Remove the fmt! syntax extension #9919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -222,9 +222,6 @@ pub fn syntax_expander_table() -> SyntaxEnv { | |||
| span: None, | |||
| } as @SyntaxExpanderTTItemTrait, | |||
| None))); | |||
| syntax_expanders.insert(intern(&"oldfmt"), | |||
There was a problem hiding this comment.
Is it worth replacing this with a syntax extension that .span_errs with something like fmt! has been replaced by format!``? (i.e. keep the fmt! macro around until at least post-0.9.)
Similar to the obsolete syntax stuff, and the removal of auto_encode.
There was a problem hiding this comment.
Hm, I actually think so. I also wouldn't be opposed to a NOTE at the end of all the errors pointing at the documentation for format!
It lived a good life, but its time has come. The groundwork is set for the official transition after the next snapshot (removal of XXX2 macros)
|
Updated to print out that |
| } | ||
|
|
||
| cx.expr_block(cx.block(fmt_sp, stms, Some(buf()))) | ||
| base::MRExpr(ecx.expr_uint(sp, 2)) |
bors
added a commit
that referenced
this pull request
Oct 19, 2013
It lived a good life, but its time has come. The groundwork is set for the official transition after the next snapshot (removal of XXX2 macros)
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 1, 2022
Link to a list of configurable lints in documentation changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It lived a good life, but its time has come. The groundwork is set for the
official transition after the next snapshot (removal of XXX2 macros)