Skip to content

update Miri #99530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2022
Merged

update Miri #99530

merged 1 commit into from
Jul 22, 2022

Conversation

RalfJung
Copy link
Member

Fixes #99461
r? @oli-obk because of lockfile changes (seems like serde is getting implicitly bumped)

@rustbot
Copy link
Collaborator

rustbot commented Jul 20, 2022

The Miri submodule was changed

cc @rust-lang/miri

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Jul 20, 2022

@bors r+ p=1 submodule update

@bors
Copy link
Collaborator

bors commented Jul 20, 2022

📌 Commit b4ae20214e8a2711f119ceb1955f7716436e33fb has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor

oli-obk commented Jul 20, 2022

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 20, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Jul 20, 2022

Oh no, seems like I broke miri in rustc after all... my local testing must have picked up the rustc from rustup. I'll get this fixed tomorrow, should be straight forward

@RalfJung
Copy link
Member Author

Argh

      error: failed to create directory `/checkout/src/tools/miri/target/test_dependencies`
      Caused by:
        Read-only file system (os error 30)

@RalfJung RalfJung mentioned this pull request Jul 21, 2022
Merged
bors added a commit to rust-lang/miri that referenced this pull request Jul 21, 2022
@bors
Auto merge of #2412 - RalfJung:x.py-fix, r=RalfJung
5a65595 
cargo-miri x.py fix

Fix for rust-lang/rust#99530 (comment)
Also make the debugging output consistent.
@RalfJung
Copy link
Member Author

We are getting there, slowly. Just a bit more normalization:

Diff< left / right > :
 error: unsupported operation: can't call foreign function: epoll_create1
<  --> CARGO_REGISTRY/epoll.rs:LL:CC
>  --> /cargo/registry/src/github.1485827954.workers.dev-1ecc6299db9ec823/mio-0.8.4/src/sys/PLATFORM/selector/epoll.rs:LL:CC

@RalfJung
Copy link
Member Author

@bors r=oli-obk

@bors
Copy link
Collaborator

bors commented Jul 21, 2022

📌 Commit c2df1c2 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 21, 2022
@bors
Copy link
Collaborator

bors commented Jul 21, 2022

⌛ Testing commit c2df1c2 with merge 31b9b01...

@bors
Copy link
Collaborator

bors commented Jul 22, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 31b9b01 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 22, 2022
@bors bors merged commit 31b9b01 into rust-lang:master Jul 22, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 22, 2022
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #99530!

Tested on commit 31b9b01.
Direct link to PR: #99530

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jul 22, 2022
@rust-highfive
📣 Toolstate changed by rust-lang/rust#99530!
77edba0 
Tested on commit rust-lang/rust@31b9b01.
Direct link to PR: <rust-lang/rust#99530>

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung).
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (31b9b01): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)		 3.1% 3.1% 1
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -2.7% -2.7% 1
Improvements 🎉
(secondary)		 -3.1% -3.1% 1
All 😿🎉 (primary) 0.2% 3.1% 2

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩

  2. number of relevant changes ↩

@RalfJung RalfJung deleted the miri branch July 22, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#99451
7 participants
@RalfJung @rustbot @rust-highfive @oli-obk @bors @rust-log-analyzer @rust-timer