don't refer to the compile-time interpreter as "Miri" #1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
approved these changes
Sep 26, 2022
JohnTitor
reviewed
Sep 26, 2022
There was a problem hiding this comment.
Could you also add miri.html to
Lines 43 to 45 in 1c79085
src/interpret.md
Outdated
| @@ -1,14 +1,13 @@ | |||
| # Miri | |||
| # Interpreter | |||
There was a problem hiding this comment.
We could move this under src/mir, placing it on the top-level dir seems a bit ambiguous to me.
There was a problem hiding this comment.
In the TOC it is listed below const-eval so maybe we should make that a folder?
RalfJung
force-pushed
the
ctfe-not-miri
branch
from
0ef8044 to
fdf6d5f
Compare
JohnTitor
approved these changes
Sep 26, 2022
|
Thanks! |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 3, 2023
…kh726 avoid 'miri' when refering to the shared interpreter This is basically the rustc source code version of rust-lang/rustc-dev-guide#1471.
Kobzol
pushed a commit
to Kobzol/rustc-dev-guide
that referenced
this pull request
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leads to a lot of confusion when people think the compile-time interpreter does the same things as Miri-the-tool. Also given that the folders in the compiler source are called
interpret, notmiri, I think it's better to just call this "the (compile-time) (MIR) interpreter", not "Miri".r? @oli-obk