-
Notifications
You must be signed in to change notification settings - Fork 543
revised a jemalloc statement in how-to-build-and-run.md #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes #227. |
Thanks! r=me when Travis passes |
The default is off, right? Is there any reason to even mention jemalloc? |
It's a fair question. This was originally included by Niko, so my inclination is to keep it unless you feel strongly about it... |
It was included because the default was "on", and turning it off can help with development. Now that it is off by default, I don't see a reason to mention it (there are many other settings in the config that aren't mentioned because the defaults are fine). Also, this PR removes the original comment (which was unique to this guide) that explains why you would turn it off, and replaces it with a comment that is confusing to me (the way I read it it, it implies that it is adding jemalloc) — the other comments explain what it does, this one explains what it doesn't do. |
I see what you mean. So @kenta7777 could you actually just remove these lines altogether? |
@mark-i-m Certainly. I'll remove these lines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I revised a jemalloc statement concerned with creating config.toml.