Some small fixes #822
Merged
Some small fixes #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
reviewed
Aug 4, 2020
| @@ -507,9 +507,10 @@ session. The overhead of doing so is a few percent of total compilation time. | |||
| Data structures used as query results could be factored in a way that removes | |||
| edges from the dependency graph. Especially "span" information is very volatile, | |||
| so including it in query result will increase the chance that that result won't | |||
| be reusable. See https://github.com/rust-lang/rust/issues/47389 for more | |||
| be reusable. See [https://github.com/rust-lang/rust/issues/47389] for more | |||
There was a problem hiding this comment.
You can use a shortcut link here I think so you don't duplicate the url below.
Suggested change
| be reusable. See [https://github.com/rust-lang/rust/issues/47389] for more | |
| be reusable. See <https://github.com/rust-lang/rust/issues/47389> for more |
There was a problem hiding this comment.
I didn't know angle brackets to turn URL into a link. Thanks!
|
I was wondering how we didn't catch the broken link then I realized crates.io returns 200 even if the page isn't found 🤦 |
This is rust-lang/crates.io#788 (comment). |
jyn514
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/rust-lang/rust/issues/47389https://crates.io/rayon