Skip to content

Add -Z self-profile info to doc builds #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jyn514 opened this issue Nov 24, 2020 · 0 comments · Fixed by #806
Closed

Add -Z self-profile info to doc builds #797

jyn514 opened this issue Nov 24, 2020 · 0 comments · Fixed by #806

Comments

@jyn514
Copy link
Member

jyn514 commented Nov 24, 2020

Currently, https://perf.rust-lang.org/detailed-query.html?commit=4ec27e4b79891b0ebc2ad71a3c4ac94f67d93f93&base_commit=09c9c9f7da72b774cc445c0f56fc0b9792a49647&benchmark=deep-vector-doc&run_name=full gives an error, even though https://perf.rust-lang.org/detailed-query.html?commit=4ec27e4b79891b0ebc2ad71a3c4ac94f67d93f93&base_commit=09c9c9f7da72b774cc445c0f56fc0b9792a49647&benchmark=deep-vector-check&run_name=full works fine. It would be great to track this info for rustdoc too.
@jyn514 jyn514 changed the title Add -Z self-profile info to doc builds Add -Z self-profile info to doc builds Nov 24, 2020
This was referenced Nov 24, 2020
Merged
Merged
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Dec 3, 2020
@bors
Auto merge of rust-lang#79586 - jyn514:crate-name, r=davidtwco
2203527 
Fix `unknown-crate` when using -Z self-profile with rustdoc

... by removing a duplicate `crate_name` field in `interface::Config`,
making it clear that rustdoc should be passing it to `config::Options` instead.

Unblocks rust-lang/rustc-perf#797.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make --self-profile work for rustdoc jyn514/rustc-perf
1 participant
@jyn514