Switch the stm32f4 benchmark to a quicker default feature
#1265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned on zulip, the current
stm32f4rustdoc benchmark takes around 10 minutes.The crate is divided into many features to selectively enable which hardware it targets, and switching from
stm32f405tostm32f410roughly halves the amount of code to compile, and more importantly also halves the time it takes to run the benchmark for me.Changing this thing after the crate has been benchmarked for a few days is likely going to look weird on graphs, the weekly report, and perfbot runs. Reducing the time this benchmark takes is probably worth this one-time annoyance.