Refactor handling of historical data #1266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
approved these changes
Apr 4, 2022
rylev
force-pushed
the
historical-data-refactor
branch
from
0ecfedb to
de6f7b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor came from realizing that we weren't using the
BenchmarkVarianceDescriptionat all and that what we were callingBenchmarkVariancesis actually just historical data we use for many different calculations (some related to variance and others not).We now more appropriately label this data as "historical" which makes the code much easier to read.
I also updated the glossary to remove terms for concepts we don't use any more and added terms for things we do use.