Skip to content

Fix for 'undefineds' on the summary, and a couple visual tweaks #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2017
Merged

Fix for 'undefineds' on the summary, and a couple visual tweaks #137

merged 1 commit into from
Aug 23, 2017

Conversation

lqd
Copy link
Member

@lqd lqd commented Aug 3, 2017

  • Fix display of undefined data
  • Always show 2 decimals for slightly better alignment (until tabular figures are used)
  • Use an em dash for "no data" or 0 instead of "-"

Here's how not-that-different it looks :)
screen shot 2017-08-04 at 00 43 08

@Mark-Simulacrum
Copy link
Member

Looks good to me. I'll wait for travis to pass and then merge and deploy.

@lqd
Copy link
Member Author

lqd commented Aug 23, 2017

@Mark-Simulacrum it seems to have passed :)

@Mark-Simulacrum
Copy link
Member

Oh, sorry! Totally forgot about this.

@Mark-Simulacrum Mark-Simulacrum merged commit ae42e19 into rust-lang:master Aug 23, 2017
@lqd lqd deleted the fix-undefined branch August 23, 2017 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lqd @Mark-Simulacrum