Show at the top of the timeline when the current benchmark is expected to finish #2319
+57
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
reviewed
Nov 5, 2025
| <strong> | ||
| <CommitSha tag={req.tag}></CommitSha> | ||
| </strong>{" "} | ||
| expected to end at {formattedDate}{" "} |
There was a problem hiding this comment.
We already show the absolute duration in the timeline table, I thought that the added value of this would be to show relative time ("is expected to end in 5 minutes"). We already have code for this in the old status page, so I'd just copy-paste it from there.
| :href="'https://github.com/rust-lang/rust/commit/' + tag" | ||
| > | ||
| {{ tag.substring(0, 13) }} | ||
| {{ truncate ? tag.substring(0, 13) : tag }} |
There was a problem hiding this comment.
I'd always truncate the tag if it looks like a SHA, otherwise the message will be annoyingly wide. #2318 solves showing the full SHA (but people just click on the link anyway and then copy-paste from the URL, I think).
There was a problem hiding this comment.
It's not that massive and it avoids any ambiguity which felt like some of the feedback was aimed at;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display a message saying what is currently in progress and when it is expected to finish. Or nothing if nothing is in progress.