Fix <StableSipHasher128 as Hasher>::finish not being platform agnostic

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Unreleased
 
+# 0.1.2
+
+- Fix `<StableSipHasher128 as Hasher>::finish` not being platform agnostic [#12][pr12]
+
+[pr12]: https://github.com/rust-lang/rustc-stable-hash/pull/12
+
 # 0.1.1
 
 - feat: derive `Clone` for `StableHasher` [#11][pr11]

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "rustc-stable-hash"
-version = "0.1.1"
+version = "0.1.2"
 description = "A stable hashing algorithm used by rustc"
 license = "Apache-2.0 OR MIT"
 readme = "README.md"

src/sip128.rs

@@ -529,7 +529,7 @@ impl Hasher for SipHasher128 {
         };
 
         // Combining the two halves makes sure we get a good quality hash.
-        a.wrapping_mul(3).wrapping_add(b).to_le()
+        a.wrapping_mul(3).wrapping_add(b)
     }
 }
 

src/stable_hasher/tests.rs

@@ -133,3 +133,23 @@ fn test_cloned_hasher_output() {
     assert_eq!(h1_hash, h2.finish());
     assert_ne!(h1_hash, h3.finish());
 }
+
+#[test]
+fn test_hash_trait_finish() {
+    fn hash<H: Hasher>(h: &H) -> u64 {
+        h.finish()
+    }
+
+    // Test that integers are handled consistently across platforms.
+    let test_u8 = 0xAB_u8;
+    let test_u16 = 0xFFEE_u16;
+    let test_u32 = 0x445577AA_u32;
+
+    let mut h1 = StableSipHasher128::new();
+    test_u8.hash(&mut h1);
+    test_u16.hash(&mut h1);
+    test_u32.hash(&mut h1);
+
+    assert_eq!(hash(&h1), hash(&h1));
+    assert_eq!(hash(&h1), 13655241286414701638);
+}