Skip to content

Fix sig::add_or_sub and IeeeFloat::normalize #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

beetrees
Copy link
Contributor

The Rust version of llvm/llvm-project#98721.

Fixes #11
cc @RalfJung

@beetrees
Copy link
Contributor Author

beetrees commented May 6, 2025

@tgross35 @fmease would either of you be able to take a look at this PR?

@tgross35 tgross35 self-assigned this May 6, 2025
@RalfJung
Copy link
Member

RalfJung commented May 7, 2025

Also Cc @eddyb in case you are still involved with apfloat :D

@beetrees
Copy link
Contributor Author

Ping reviewer @tgross35

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with this codebase but the logic makes sense, matches what was accepted for LLVM, and seems well tested. Sorry for the delay, thanks for the fix!

@tgross35 tgross35 merged commit 684d543 into rust-lang:main Jun 11, 2025
4 checks passed
@tgross35
Copy link
Contributor

Released in v0.2.3+llvm-462a31f5a5ab

@beetrees beetrees deleted the fix-mul-add branch June 11, 2025 02:00
@RalfJung RalfJung mentioned this pull request Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong results in some FMA cases
3 participants