Skip to content

Avoid a hir access inside get_static #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Dec 13, 2022

This is the cg_gcc counterpart to rust-lang/rust#81664. Best reviewed with whitespace changes ignored.

@antoyo
Copy link
Contributor

antoyo commented Dec 13, 2022

It seems like my rebase of my GCC fork broke some tests.

@antoyo
Copy link
Contributor

antoyo commented Dec 21, 2022

Please ping me in january if I forget to fix the bug.

@antoyo
Copy link
Contributor

antoyo commented Jan 12, 2023

You should now be able to rebase and have the CI pass.
If it segfaults (issue #245), just re-run the CI for now.

@antoyo antoyo merged commit f6ad065 into rust-lang:master Jan 14, 2023
@antoyo
Copy link
Contributor

antoyo commented Jan 14, 2023

Thanks a lot!

@bjorn3 bjorn3 deleted the no_codegen_hir branch January 14, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants