Rustfmt drops 'default' from 'default fn …' using specialization

[killercup]

Since specialization is only available in nightly (and maybe still changing), it's not much of a priority, though.

cf. rust-lang/miri#6

[zitsen]

I'm waiting for this impl.

[julienXX]

I'd like to try to fix this one if no one is already working on it.

[regexident]

line hint (spoiler alert! 😉 )

[lqd]

To me it looked like the syntex visitor didn't pass the defaultness ? (but I'm unfamiliar with both syntex and rustfmt so I could be very mistaken)

[regexident]

To me it looked like the syntex visitor didn't pass the defaultness ? (but I'm unfamiliar with both syntex and rustfmt so I could be very mistaken)

That's true in fact, afaikt:

syntax::ast::TraitItemKind::Method(MethodSig, Option<P<Block>>)

pub struct MethodSig {
    pub unsafety: Unsafety,
    pub constness: Constness,
    pub abi: Abi,
    pub decl: P<FnDecl>,
    pub generics: Generics,
}

[lqd]

@julienXX salut Julien ;)

I think I'm close-ish to making a PR as I was talking about this issue with @nrc on IRC earlier today, would you mind if I took a crack at it ?

[julienXX]

@lqd no problem 👍

[nrc]

@julienXX if you want to work on a rustfmt, there are a bunch of good issues - https://github.com/rust-lang-nursery/rustfmt/issues?q=is%3Aopen+is%3Aissue+label%3Aeasy - I'm happy to mentor any of them - either ping me on irc or comment on the bug.

[julienXX]

@nrc will do, thanks :)

[jaredthecoder]

@nrc I'd love to jump on some of those. I'll find you on IRC if I have any issues.