Skip to content

Fix #1021: Handle .. in tuple / tuple struct patterns #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2016
Merged

Fix #1021: Handle .. in tuple / tuple struct patterns #1151

merged 1 commit into from
Sep 13, 2016

Conversation

sinkuu
Copy link
Contributor

@sinkuu sinkuu commented Sep 6, 2016

No description provided.

@sinkuu sinkuu changed the title Fix #1021 Fix #1021: Handle .. in tuple / tuple struct patterns Sep 6, 2016
@sinkuu sinkuu mentioned this pull request Sep 6, 2016
Closed
@sinkuu sinkuu force-pushed the issue1021 branch 3 times, most recently from 279f475 to 8436ecc Compare September 7, 2016 11:12
nrc
nrc reviewed Sep 8, 2016
View reviewed changes
src/patterns.rs

enum TuplePatField<'a> {
Pat(&'a ptr::P<ast::Pat>),
Dotdot(BytePos, BytePos),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we store a span here rather than two BytePos's?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@nrc nrc merged commit f9712b0 into rust-lang:master Sep 13, 2016
@nrc
Copy link
Member

nrc commented Sep 13, 2016

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sinkuu @nrc