Handle \r like \n to avoid difference of length between LF and CRLF line endings #1347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ghost
changed the title
nrc
suggested changes
Feb 28, 2017
src/lib.rs
Outdated
| @@ -482,7 +477,7 @@ fn format_lines(text: &mut StringBuffer, name: &str, config: &Config, report: &m | |||
| }); | |||
| } | |||
|
|
|||
| if c == '\n' { | |||
| if c == '\n' || c == '\r' { | |||
There was a problem hiding this comment.
I don't think this is quite right - a line ending in \r\n will be counted as two lines rather than one. I think it might be better to keep the original treatment, but don't increment line_len, although that assumes line_len is only used for the max line length test.
There was a problem hiding this comment.
I think you're right, my bad. By the way, if you have a better name for this PR, don't hesitate :P
ghost
closed this
added 2 commits
March 1, 2017 20:51
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc. #1335