bin: Add a very simple rustfmt-format-diff. #1842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
nrc
approved these changes
Jul 30, 2017
Member
nrc
left a comment
nrc
left a comment
There was a problem hiding this comment.
Awesome, thank you! This looks great. Only comment about the code is about using logging. Could you file a tracking issue for things you think are missing for making this a 'complete' feature please?
src/bin/rustfmt-format-diff.rs
Outdated
| verbose: bool, | ||
| ) -> Result<(), FormatDiffError> { | ||
| if files.is_empty() || ranges.is_empty() { | ||
| if verbose { |
Member
There was a problem hiding this comment.
Could you use logging (debug! or info!) rather than if verbose here and below?
Contributor
Author
There was a problem hiding this comment.
Sure, I was following the format cargo-fmt was using, but will do.
This patch introduces a super-simple format-diff tool, that allows you to do: ``` git diff | rustfmt-format-diff -p 1 ``` To format your current changes. For now it doesn't accept too much customisation, and it basically calls rustfmt with the default configuration, but more customisation can be added in the future if needed.
emilio
force-pushed
the
rustfmt-format-diff
branch
from
4238baa to
068bcad
Compare
Member
|
Awesome, thank you! |
Contributor
|
Is there a reason why this is a seperate binary, rather than a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a super-simple format-diff tool, that allows you to do:
To format your current changes.
For now it doesn't accept too much customisation, and it basically calls rustfmt
with the default configuration, but more customisation can be added in the
future if needed.