Fixing macOS Travis setup #2504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidalber
commented
Mar 2, 2018
| source env/bin/activate && | ||
| python --version && |
There was a problem hiding this comment.
I added this so that we can see in the logs which version of Python is being used. We could take it out, but I'm curious to see if it flips to Python 3 in the coming days. It's currently "Python 2.7.14".
|
Thanks! |
frol
added a commit
to frol/fs-utils-rs
that referenced
this pull request
May 2, 2018
The solution is backported from rustfmt: * rust-lang/rustfmt#2229 * rust-lang/rustfmt#2504
Byron
pushed a commit
to Byron/fs-utils-rs
that referenced
this pull request
May 9, 2018
The solution is backported from rustfmt: * rust-lang/rustfmt#2229 * rust-lang/rustfmt#2504
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macOS Travis build is broken. I believe the cause is Homebrew changed the
pythonformula to be Python 3. Thus, when we try tobrew install python3we are really trying install thepythontarget, which is already (currently) Python 2 in the Travis image.I first tried fixing this by upgrading the
pythonformula. This added a lot of time to the build, and wasn't quite working before I realized thattravis-cargodoes not care whether it's executing in a Python 2 or Python 3 interpreter. Thus, I just dropped the whole "try to get a Python 3 virtual environment" angle. Currently, this is running using Python 2, but I suspect that Travis will update the image sometime and it will then by Python 3.