Restore cargo fmt behavior in workspaces #2513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrc
reviewed
Mar 8, 2018
src/cargo-fmt/main.rs
Outdated
| let current_dir = env::current_dir()?; | ||
| let current_dir_manifest = current_dir.join("Cargo.toml"); | ||
| let workspace_root_path = PathBuf::from(&metadata.workspace_root); | ||
| let in_workspace_root = workspace_root_path == current_dir; |
There was a problem hiding this comment.
You should probably canonicalise the paths before comparing them (although tbh, I don't know how equality for paths work so it might not be necessary).
|
Thanks! Could you rebase please? |
added 3 commits
March 9, 2018 07:24
Previously, cargo fmt invoked without parameters would only format the crate in the current directory, even if the crate was part of a workspace. This patch restores that behavior.
|
Done! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, cargo fmt invoked without parameters would
only format the crate in the current directory, even if
the crate was part of a workspace. This patch restores
that behavior.