Fix error_on_unformatted and skip_children override#2600
Merged
nrc merged 1 commit intorust-lang:masterfrom Apr 6, 2018
Merged
Fix error_on_unformatted and skip_children override#2600nrc merged 1 commit intorust-lang:masterfrom
nrc merged 1 commit intorust-lang:masterfrom
Conversation
Currently, error_on_unformatted and skip_children options specified in the config file are discarded. This happens because CLI options have a higher priority, but we coerce an absence of a `bool` option to `false`. In this scenario, an absence of a `bool` option is indistinguishable from explicetely set as `false`. We should coerce it to `None` instead, so it does not override the one in the config file.
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
error_on_unformattedandskip_childrenoptionsspecified in the config file are discarded.
This happens because CLI options have a higher priority,
but we coerce an absence of a
booloption tofalse.In this scenario, an absence of a
booloption is indistinguishablefrom explicitly set as
false. We should coerce it toNoneinstead,so it does not override the one in the config file.
Issue: #2565