Skip to content

Format label break #2726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2018
Merged

Format label break #2726

merged 2 commits into from
May 21, 2018

Conversation

csmoe
Copy link
Member

@csmoe csmoe commented May 21, 2018

Fixes #2722

@csmoe
Copy link
Member Author

csmoe commented May 21, 2018

Oops, made a mistake with 'label', will fix later

@topecongiro topecongiro merged commit 1b3257d into rust-lang:master May 21, 2018
@topecongiro
Copy link
Contributor

Thank you!

@csmoe csmoe deleted the label_break branch May 22, 2018 00:02
@Amanieu
Copy link
Member

Amanieu commented Jun 6, 2018

This is broken. Look at the test file: the labels are being deleted.

@csmoe csmoe mentioned this pull request Jun 7, 2018
@zesterer
Copy link

Any update on when this might be fixed, or whether help is needed in fixing this? We're having similar problems with our nightly codebase.

@Amanieu
Copy link
Member

Amanieu commented Sep 30, 2018

@zesterer You need to update your nightly. This has been fixed for a while: rust-lang/rust#51739

@zesterer
Copy link

@Amanieu Aha, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants