Skip to content

Handle const generic bounds in structs #4220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2020
Merged

Handle const generic bounds in structs #4220

merged 1 commit into from
May 31, 2020

Conversation

ayazhafiz
Copy link
Contributor

Closes #4218

calebcartwright
calebcartwright approved these changes May 31, 2020
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@calebcartwright calebcartwright merged commit 494452b into rust-lang:master May 31, 2020
@ytmimi
Copy link
Contributor

ytmimi commented Apr 1, 2022

This was unintentionally backported by #5274

@ytmimi ytmimi added 1x-backport:pending Fixed/resolved in source but not yet backported to a 1x branch and release 1x-backport:completed and removed backport-triage 1x-backport:pending Fixed/resolved in source but not yet backported to a 1x branch and release labels Apr 1, 2022
@ytmimi
Copy link
Contributor

ytmimi commented Apr 1, 2022 •
edited
Loading

I may have spoken too soon 😔, rustfmt 1.4.38-nightly (5ff7b632 2022-03-29) doesn't format the test case used in this PR correctly.

pub struct Arr
where
    [u8; { 10 / 2 }]: Send, {}

We should still probably backport this / investigate what's going on. The given implementation might be the correct approach instead of what was merged in #5274.

@calebcartwright calebcartwright mentioned this pull request Apr 2, 2022
Merged
@ytmimi ytmimi mentioned this pull request Apr 3, 2022
Open
@ytmimi ytmimi added 2x-port:pending 1x-backport:pending Fixed/resolved in source but not yet backported to a 1x branch and release and removed backport-triage 2x-port:pending labels Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
1x-backport:pending Fixed/resolved in source but not yet backported to a 1x branch and release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

division in where clause leads to incorrect formatting
4 participants
@ayazhafiz @ytmimi @calebcartwright @karyon