Read the original file for comparing/detecting newline #4236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topecongiro
force-pushed
the
windows-newline-issues
branch
from
bbe7fa1 to
0cf74df
Compare
topecongiro
commented
Jun 6, 2020
| std::io::Error::from(std::io::ErrorKind::InvalidInput), | ||
| ))?)?, | ||
| }; | ||
| apply_newline_style(config.newline_style(), &mut visitor.buffer, &original_text); |
There was a problem hiding this comment.
We need to pass the original file content to apply_newline_style.
topecongiro
commented
Jun 6, 2020
| @@ -206,13 +206,6 @@ impl ParseSess { | |||
| Rc::clone(source_file.src.as_ref().unwrap()), | |||
| ) | |||
| } | |||
|
|
|||
| pub(crate) fn get_original_snippet(&self, file_name: &FileName) -> Option<Rc<String>> { | |||
There was a problem hiding this comment.
This method is no longer used, and thus removed.
topecongiro
commented
Jun 6, 2020
| @@ -62,9 +62,6 @@ impl SnippetProvider { | |||
| } | |||
| } | |||
|
|
|||
| pub(crate) fn entire_snippet(&self) -> &str { | |||
There was a problem hiding this comment.
This method is no longer used, and thus removed.
calebcartwright
added
1x-backport:pending
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4097.