Skip to content

Fix import_granularity option when the use tree has an alias #5209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 4, 2022
Merged

Fix import_granularity option when the use tree has an alias #5209

merged 2 commits into from
Feb 4, 2022

Conversation

scampi
Copy link
Contributor

@scampi scampi commented Jan 31, 2022

Close #5131

calebcartwright
calebcartwright reviewed Feb 2, 2022
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm, though would you mind adding tests that have the One and Crate variants too? Refs #5166

@calebcartwright calebcartwright mentioned this pull request Feb 2, 2022
Closed
@scampi
Copy link
Contributor Author

scampi commented Feb 3, 2022

Thanks for the review, I've added tests in my latest commit.

@calebcartwright
Copy link
Member

Thanks!

@calebcartwright calebcartwright merged commit fd6e11c into master Feb 4, 2022
@scampi scampi deleted the issue-5131 branch February 4, 2022 08:06
@ytmimi ytmimi mentioned this pull request Feb 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: imports_granularity = "Module"/"Crate"/"One" crash code when de-duplicate dependencies
3 participants
@scampi @calebcartwright @ytmimi