Updated how nested function calls are overflowed #5443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5356
I feel like there's got to be a simpler way to handle this, so any recommendations on how we can update the implementation are greatly appreciated. I noticed that in the original issue the
callee
was being split overly multiple lines and tried to use that to conditionally determine whether we rewrite the expression as we did before by just callingexpr.rewrite
or go down a path where we do some extra work to figure out how we'll rewrite the overflowing function call.I found it a bit strange that in some cases we need to indent the shape, while in others we need to unindent it, but I imagine that has something to do with what's happening when
last_item_shape
is called.