Add option to control trailing zero in floating-point literals#5834
Add option to control trailing zero in floating-point literals#5834ytmimi merged 8 commits intorust-lang:masterfrom
Conversation
|
Hey @amatveiakin I know this hasn't gotten much attention from the team, but I wanted to check back in and see if you're still interested in working on this. |
ytmimi
left a comment
ytmimi
left a comment
There was a problem hiding this comment.
Just wrapped up my initial review on this. Overall I think this is a good start, but I'd like us to expand on the test cases.
|
Apologies for the slow reply. Please take another look. |
|
@amatveiakin No worries. I'll likely have some time to get back to this later this week. For your awareness I want to let you know that I just merged #6085, and I'd really like to see tests with range expressions like the ones in the PR. I want to make sure that the new |
|
Any updates on this effort? |
|
@Keavon sorry, this completely slipped my mind. I'm going to take a look this weekend. |
|
@ytmimi you were absolutely right: my original implementation incorrectly reformatted |
|
I should have some time to revisit this later in the week. Thanks for following up on the implementation! |
ytmimi
left a comment
ytmimi
left a comment
There was a problem hiding this comment.
Thanks again for revisiting this. I've left some additional feedback on the PR
ytmimi
left a comment
ytmimi
left a comment
There was a problem hiding this comment.
Thanks for helping to implement this new option. After the tracking issue link is updated I can merge this.
- Revert changes to rewrite_int_lit. - Implement float_lit_ends_in_dot independently of rewrite_float_lit. - Remove rewrite_float_lit_inner: it is not needed after the float_lit_ends_in_dot rewrite.
|
Thanks again for your help on this! |
ytmimi
added
release-notes
|
Stabilization status: #6471 |
3 participants
This is my first contribution to rustfmt. Feel free to nitpick :)
Also please tell me if I did the tests right. Three separate test files seem like a lot for such a small feature, but I don't see how else I could check all configurations.
Closes #3187