Chains tabbed indent

[thorbenk]

When breaking chains, the indentation was too large in "Tabbed" mode. Is this the correct way to fix this?

[marcusklaas]

That doesn't look right to me. If I remember correctly, the chain_base_indent option was created to set the indentation of chain bases which ended in a nearly blank line.

For example:

match x {
    Some(val) => val,
    None => default,
}
    .this_is_tabbed_mode();

[marcusklaas]

Could you post the example (input, output) which prompted this pull request?

[thorbenk]

Thanks for your explanation! Without a rustfmt.toml, rustfmt changes my code like this:

 pub fn read_and_rotate(img_filename: &Path) -> DynamicImage {
     let exif_orientation = rexiv2::Metadata::new_from_path(img_filename.to_str().unwrap())
-        .map(|e| e.get_orientation());
+                               .map(|e| e.get_orientation());

(You can also take the test from my commit as an example)

I'm not sure why it is indented so heavily (and to what reference column the aligning happens here), but guessed that this is due to the "Visual" default settings. I would like to just indent once here, like in the "Tabbed" modes. With this, I'm leaning towards a style as described in #454.

[marcusklaas]

Aha! There's no option to change this behaviour at this moment. Could you create a new one of the same type and check for that? I think you'd also have to consider Inherit, but that's just one level of indentation less deep than Tabbed.

[thorbenk]

OK, pushed a new version. Does that go in the right direction?

[marcusklaas]

Perfect! Thanks for the changes.