config: Introduce RunConfig for config related to a single run #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an exported macro `impl_default_and_override` to `util`, allowing that functionality to be reused without also implementing parsing and documentation printing.
This commit introduces a `RunConfig` struct, and threads it through all libraries, binaries, and tests. While initially empty, this will be a place to store configuration related to a single run of `rustfmt`, as distinct from configuration read in from the `rustfmt.toml` file. Examples of such per-run settings include: - the `write_mode` override - the `--verbose` flag - the `--skip-children` flag - line ranges to restrict formatting to; see rust-lang#434 These will be added to `RunConfig` in later commits. refs rust-lang#434
Contributor
Author
|
Thinking about this a bit more, it might not be the right abstraction. Using the same |
Member
|
I like the sound of the alternative you describe better - sounds like less complexity. |
Contributor
Author
|
Yeah, I think so too. The realisation came up while trying to move I'll try and put together a PR with the alternative today so that I can actually start on #434! |
Contributor
Author
|
Closing in favor of #801. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config: Introduce RunConfig for config related to a single run
This pull request introduces a
RunConfigstruct, and threads itthrough all libraries, binaries, and tests. It carries configuration
related to a single run of
rustfmt, as distinct from configurationread in from the
rustfmt.tomlfile. Theverboseandskip-childrensettings are moved to
RunConfig.Other examples of such per-run settings:
write_modeoverriderefs #434