config: Use write_mode from config #812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamalmarhubi
force-pushed
the
write-mode-from-config
branch
from
6e68d23 to
2159c8b
Compare
| @@ -112,6 +113,14 @@ fn match_cli_path_or_file(config_path: Option<PathBuf>, | |||
| fn update_config(config: &mut Config, matches: &Matches) { | |||
| config.verbose = matches.opt_present("verbose"); | |||
| config.skip_children = matches.opt_present("skip-children"); | |||
|
|
|||
| let write_mode = matches.opt_str("write-mode").map(|ref s| { | |||
| WriteMode::from_str(s).expect(&format!("Invalid write-mode: {}", s)) | |||
There was a problem hiding this comment.
We shouldn't panic due to invalid user input. We should exit gracefully with the message.
|
LGTM, just that one comment to address |
|
I prefer the version you've currently implemented, thanks! However, you now have a test error. Could you also squash the commits before I merge? |
This commit tidies up handling of `write_mode` by setting it in the config at the start, and removing the `write_mode` parameter threaded throughout the formatting process.
kamalmarhubi
force-pushed
the
write-mode-from-config
branch
from
732e18b to
14dbac5
Compare
The formating tool that tests its own formatting... keeps biting! :-)
Should be all done! |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit tidies up handling of
write_modeby setting it in theconfig at the start, and removing the
write_modeparameter threadedthroughout the formatting process.