Skip to content

clippy1.rs passed without any modifications #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ColonelJ opened this issue Dec 12, 2021 · 1 comment · Fixed by #890
Closed

clippy1.rs passed without any modifications #888

ColonelJ opened this issue Dec 12, 2021 · 1 comment · Fixed by #890

Comments

@ColonelJ
Copy link

Possible that clippy no longer raises any error for y != x with floats; the exercise didn't show any errors.

$ rustc --version
rustc 1.57.0 (f1edd0429 2021-11-29)
$ rustlings --version
v4.6.0
$ ls -la
total 236
drwxrwxr-x  7 jason jason  4096 Dec 12 21:28 .
drwxr-xr-x  5 jason jason  4096 Dec 12 13:28 ..
-rw-rw-r--  1 jason jason 26858 Dec 12 13:28 .all-contributorsrc
-rw-rw-r--  1 jason jason 18856 Dec 12 13:28 Cargo.lock
-rw-rw-r--  1 jason jason   457 Dec 12 13:28 Cargo.toml
-rw-rw-r--  1 jason jason 32702 Dec 12 13:28 CHANGELOG.md
-rw-rw-r--  1 jason jason    88 Dec 12 13:28 .clog.toml
-rw-rw-r--  1 jason jason  4222 Dec 12 13:28 CONTRIBUTING.md
-rw-rw-r--  1 jason jason  1546 Dec 12 13:28 default_out.txt
-rw-rw-r--  1 jason jason   102 Dec 12 13:28 .editorconfig
drwxrwxr-x 23 jason jason  4096 Dec 12 19:48 exercises
drwxrwxr-x  8 jason jason  4096 Dec 12 13:28 .git
-rw-rw-r--  1 jason jason   117 Dec 12 13:28 .gitignore
-rw-rw-r--  1 jason jason   175 Dec 12 13:28 .gitpod.yml
-rw-rw-r--  1 jason jason 37148 Dec 12 13:28 info.toml
-rw-rw-r--  1 jason jason  3022 Dec 12 13:28 install.ps1
-rwxrwxr-x  1 jason jason  3787 Dec 12 13:28 install.sh
-rw-rw-r--  1 jason jason  1095 Dec 12 13:28 LICENSE
-rw-rw-r--  1 jason jason 39077 Dec 12 13:28 README.md
-rw-rw-r--  1 jason jason   104 Dec 12 13:28 .replit
drwxrwxr-x  2 jason jason  4096 Dec 12 13:28 src
drwxrwxr-x  4 jason jason  4096 Dec 12 19:58 target
drwxrwxr-x  3 jason jason  4096 Dec 12 13:28 tests
$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.6 LTS
Release:	18.04
Codename:	bionic
@frvannes16
Copy link
Contributor

I experienced this as well on rustc 1.57.0.
Looks like float_cmp was recently downgraded from 'correctness' to 'pedantic': rust-lang/rust-clippy@3ad3c51#diff-5d66e1251bbfd7bc6f38d570e3bbe87424568fc8535678b654b9eda155da44a6

This exercise should be modified to trigger a correctness check instead.

frvannes16 added a commit to frvannes16/rustlings that referenced this issue Dec 15, 2021
bugaolengdeyuxiaoer pushed a commit to bugaolengdeyuxiaoer/rustlings that referenced this issue Dec 28, 2021
ppp3 pushed a commit to ppp3/rustlings that referenced this issue May 23, 2022
dmoore04 pushed a commit to dmoore04/rustlings that referenced this issue Sep 11, 2022
Spacebody pushed a commit to Spacebody/my-rustlings that referenced this issue Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants