Skip to content

Demote deprecation warning to verbose info #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kinnison opened this issue Dec 9, 2019 · 3 comments · Fixed by #2162
Closed

Demote deprecation warning to verbose info #2149

kinnison opened this issue Dec 9, 2019 · 3 comments · Fixed by #2162

Comments

@kinnison
Copy link
Contributor

kinnison commented Dec 9, 2019

After a lot of discussion with reddit and friends, it seems that deprecating rustup install and rustup uninstall would have consequences I'd not considered (printed books) and as such it'd be unpleasantly surprising for new users to be told the book they bought was wrong.

As such, we should demote the deprecation warning code from warn!() to verbose!() and make it clear that the reason for the message is that until true alias support is added, these may not function quite as the toolchain XXX commands would.

Long-term we want to replace the deprecated subcommands with true aliases so that this can't be a problem again in the future.

@kinnison
Copy link
Contributor Author

kinnison commented Dec 9, 2019

If you'd like to tackle this, please indicate so on the issue and find me on the Rustup discord channel if you want to chat about it.

@jaronsummers
Copy link

The printed book use case is largely handled by just replacing the existing code with a message that says to use rustup toolchain install instead, isn't it? That code would be simple enough that it wouldn't be buggy, nor would it be a duplication of the rustup toolchain install code.

@kinnison
Copy link
Contributor Author

@jaronsummers This issue was raised precisely because people were worried about such a deprecation message causing undue concern to newcomers.

kinnison added a commit to kinnison/rustup that referenced this issue Dec 16, 2019
We decided that the deprecation messages ought to be verbose
messages (i.e. only in --verbose mode) rather than warnings.

Fixes: rust-lang#2149

Signed-off-by: Daniel Silverstone <[email protected]>
@kinnison kinnison self-assigned this Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants