Skip to content

Rename ~/.multirust to ~/.rustup. #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brson opened this issue Jun 21, 2016 · 11 comments
Closed

Rename ~/.multirust to ~/.rustup. #537

brson opened this issue Jun 21, 2016 · 11 comments

Comments

@brson
Copy link
Contributor

brson commented Jun 21, 2016

This is a legacy name that needs to be transitioned away from.

@mgattozzi
Copy link

I'd like to take a stab at this issue. I was wondering what this would entail changing in the code in order to make this update smooth for existing users as well as making sure all new installs will follow this convention.

mjdwitt pushed a commit to mjdwitt/rustup.rs that referenced this issue Jun 23, 2016
This should be reverted when rust-lang#537 is fixed.
@brson
Copy link
Contributor Author

brson commented Jun 24, 2016

@mgattozzi The story for upgrading rustup data formats isn't very consistent right now.

For this I would suggest the following:

  • At startup ~/.multirust exists and looks valid (the configuration loads), and ~/.rustup does not exist, just attempt the rename silently, print an error if it fails.
  • If ~/.multirust exists and looks valid and ~/.rustup already exists, then print an error saying to the effect of 'I want to rename this dir but I can't. Help me'.

In both cases we could continue on error using ~/.multirust but the complexity probably isn't worth it.

One tricky bit here is that the initial update needs to use either the ~/.multirust directory so that upgrades from previous releases work, but also from the ~/.rustup directory be defensive against downgrades and other weird scenarios. This code path is in self_update::self_replace.

@fenhl
Copy link

fenhl commented Jul 14, 2016

Please consider switching to the XDG Base Directory specification instead, to remove clutter from our home directories.

@flying-sheep
Copy link

can we close this please and put a 0.4 milestone on #247?

i’ll immediately start working on it once i get green light (in both cargo and here)

@brson
Copy link
Contributor Author

brson commented Jul 19, 2016

@flying-sheep No we can't do that. There is an RFC on the subject if you would like to follow.

@flying-sheep
Copy link

flying-sheep commented Jul 20, 2016

thanks, i already do. and why can’t we do that? won’t the RFC be followed?

@steveklabnik
Copy link
Member

won’t the RFC be followed?

The RFC has not yet been accepted.

@flying-sheep
Copy link

of course, sorry. then i’ll wait until it is!

@Diggsey
Copy link
Contributor

Diggsey commented May 4, 2017

This happened.

@Diggsey Diggsey closed this as completed May 4, 2017
@Siilwyn
Copy link

Siilwyn commented May 6, 2017

@Diggsey in the readme it still states .multirust is used though. The description of this issue is to get rid of that name right?

@johndrinkwater
Copy link

A fresh Rust install still creates ~/.multirust/

lrwxrwxrwx 1 john john    18 Nov  5 18:21 .multirust -> /home/john/.rustup
drwxrwxr-x 6 john john  4096 Nov  5 18:22 .rustup

Could this ‘legacy name’ be transitioned away quicker?
Intent of the issue seems to still be WIP, so maybe it could be reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants