Skip to content

Escape Windows backslash when outputing to markdown #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2020
Merged

Escape Windows backslash when outputing to markdown #2274

merged 2 commits into from
Apr 16, 2020

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Mar 29, 2020 •
edited
Loading

Closes #2272
Duplicate close #2174

@tesuji tesuji force-pushed the escape-nt-backslash branch from ad54f2d to 0faa8cd Compare March 29, 2020 13:45
@tesuji
Copy link
Contributor Author

tesuji commented Mar 29, 2020

Result from windows: https://github.com/rust-lang/rustup/pull/2274/checks?check_run_id=543340236#step:15:21

@tesuji tesuji force-pushed the escape-nt-backslash branch 4 times, most recently from 356f018 to 4d18bc1 Compare April 1, 2020 04:38
@tesuji tesuji changed the title Escape nt backslash Escape Windows backslash when outputing to markdown Apr 1, 2020
rbtcollins
rbtcollins approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@rbtcollins rbtcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I'm not sure if the variation between windows and unix needs to be as large as it is.

kinnison
kinnison suggested changes Apr 4, 2020
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are [do not merge] commits in this sequence. Please rebase them away.

@tesuji tesuji force-pushed the escape-nt-backslash branch from 4d18bc1 to cac1d3a Compare April 4, 2020 13:08
@tesuji tesuji requested a review from kinnison April 12, 2020 00:32
@kinnison kinnison merged commit 2138b7a into rust-lang:master Apr 16, 2020
@tesuji tesuji deleted the escape-nt-backslash branch April 16, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbtcollins rbtcollins rbtcollins approved these changes

@kinnison kinnison Awaiting requested review from kinnison

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing backslash in printed CARGO_HOME path on Windows
3 participants
@tesuji @rbtcollins @kinnison