-
Notifications
You must be signed in to change notification settings - Fork 946
fix(dist/triple): ensure dist::triple::known
is up to date with platforms
#3841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
May 25, 2024
platforms
at comptimedist::triple::known
is up to date with platforms
djc
reviewed
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I have a bunch of small suggestions but this is looking pretty good!
(Sorry for taking a while to review it.)
djc
approved these changes
Jun 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3783.
By introducing
platforms
as a new dependency, this PR tries to address both the problems that come with generated source files withinsrc
, as well as the issue that the list of known target triples is a moving target:build.rs
already depends on full target triples to work, it no longer has toinclude!()
some file insidesrc
;platforms
, so the output will not change as long asplatforms
' version is locked.Concerns
Are custom triples involved in this change?No, they are handled by another mechanism (CustomToolchainName
).rustup/src/dist/triple.rs
Lines 70 to 79 in 2a5a69e