Skip to content

implements quiet flag in rustup-init.sh #3910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2024
Merged

implements quiet flag in rustup-init.sh #3910

merged 1 commit into from
Jun 30, 2024

Conversation

vic1707
Copy link
Contributor

@vic1707 vic1707 commented Jun 25, 2024

as discussed in #3350

rami3l
rami3l previously approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks a lot!

@rami3l rami3l added this pull request to the merge queue Jun 26, 2024
@rami3l rami3l removed this pull request from the merge queue due to a manual request Jun 26, 2024
@rami3l rami3l added this pull request to the merge queue Jun 26, 2024
@rami3l rami3l mentioned this pull request Jun 26, 2024
Closed
@rami3l rami3l removed this pull request from the merge queue due to a manual request Jun 26, 2024
@rami3l rami3l dismissed their stale review June 26, 2024 02:43

Concern: incorrect output format

rami3l
rami3l reviewed Jun 26, 2024
View reviewed changes
rami3l
rami3l reviewed Jun 26, 2024
View reviewed changes
@vic1707
Copy link
Contributor Author

vic1707 commented Jun 28, 2024

Hi @rami3l may I ask you for an updated review 😁 ?
I'd like to have your opinion on some of the choices I've made, in particular the fact that the err function no longer exits on its own.

rami3l
rami3l reviewed Jun 29, 2024
View reviewed changes
rami3l
rami3l reviewed Jun 29, 2024
View reviewed changes
Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! You're closer than ever to the finish line :)

rami3l
rami3l reviewed Jun 29, 2024
View reviewed changes
rami3l
rami3l reviewed Jun 29, 2024
View reviewed changes
@vic1707
Copy link
Contributor Author

vic1707 commented Jun 29, 2024

I think we're good now 🤔

rami3l
rami3l approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@rami3l rami3l added this pull request to the merge queue Jun 30, 2024
@rami3l rami3l linked an issue Jun 30, 2024 that may be closed by this pull request
shouldn't install script be quiet? #3350
Closed
Merged via the queue into rust-lang:master with commit efa576d Jun 30, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rami3l rami3l rami3l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shouldn't install script be quiet?
2 participants
@vic1707 @rami3l